Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update refund API call to take into account line items #82

Closed
Noah-Silvera opened this issue Jun 23, 2021 · 1 comment
Closed

Update refund API call to take into account line items #82

Noah-Silvera opened this issue Jun 23, 2021 · 1 comment
Labels
wontfix This will not be worked on

Comments

@Noah-Silvera
Copy link
Member

Noah-Silvera commented Jun 23, 2021

Our usage of the "create refund" API endpoint does not pass individual line items, just totals.

def refund_params(reimbursement)

Different product types can be taxed different amounts under different tax codes, so it's important to ensure that we know which item(s) the refund was issued for.

@Noah-Silvera Noah-Silvera added this to the TaxJar Certification milestone Jun 23, 2021
@Noah-Silvera Noah-Silvera added the good first issue Good for newcomers label Jun 23, 2021
@Noah-Silvera
Copy link
Member Author

This is still technically a problem, but a new refund_transaction_params method was created which takes into account line items, and this old refund endpoint will likely be deprecated. We should fix this if someone requests it, but it's not high priority

@Noah-Silvera Noah-Silvera added wontfix This will not be worked on and removed good first issue Good for newcomers labels Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
1 participant