Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wind charges trigger the mod to show the custom explosive particles #32

Closed
Daniel99j2 opened this issue May 4, 2024 · 2 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@Daniel99j2
Copy link

Yes, I understand that Wind Charges are still in development. However, they are currently accessible and when 1.21 releases, this issue will be more applicable.

When a wind charge explodes, they cause the custom particles for an expolsion to show, replacing the wind burst particles.
To reproduce,

  1. Create a world with experiments
  2. Run /summon minecraft:wind_charge ~ ~ ~ {Motion:[0.0d, -1.0d, 0.0d]}
  3. Notice that the particles are for normal explosions

2024-05-04_13 00 11

@Superkat32
Copy link
Owner

Nice catch! The issue makes sense because I believe the wind charge's explosions are still treated as normal explosions(without block/entity damage) in the code.

I might take advantage of this though and make a special effect for wind charge explosions, along with a config option to disable them. I'll look into it when I have the time 😃

@Superkat32 Superkat32 self-assigned this May 4, 2024
@Superkat32 Superkat32 added the bug Something isn't working label May 4, 2024
@Superkat32
Copy link
Owner

Fixed in 1.2.3(totally didn't forget to mark this as complete yesterday)!
No special wind effect has been added just yet, as I couldn't get it looking the way I wanted just yet. But, I may still do that in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants