Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

Adds Twitter/github/facebook/linkedin profiles and uses sidekiq instead of delayedjob #15

Closed
wants to merge 4 commits into from

Conversation

heroic
Copy link

@heroic heroic commented Jun 27, 2013

Refs #9, #13

@unamashana
Copy link
Member

@heroic in general it's better to create separate issues for different tasks and then merge them separately. Mixing functionality makes it harder to test. Thoughts @avinasha ?

@@ -1,8 +1,9 @@
source 'http://rubygems.org'

ruby '1.9.3'
ruby '2.0.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too many moving parts in this commit

@avinasha
Copy link

@prateekdayal makes sense... @heroic can you split this commit into diff issues? It will help us merge and deploy.. Thanks

@heroic
Copy link
Author

heroic commented Jun 27, 2013

Sure
On 27-Jun-2013 4:19 PM, "Avinasha Shastry" [email protected] wrote:

@prateekdayal https://github.com/prateekdayal makes sense... @heroichttps://github.com/heroiccan you split this commit into diff issues? It will help us merge and
deploy.. Thanks


Reply to this email directly or view it on GitHubhttps://github.com//pull/15#issuecomment-20110704
.

@heroic heroic closed this May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants