Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the way jokes are served #535

Closed
DanBuxton opened this issue Dec 27, 2024 · 1 comment
Closed

Change the way jokes are served #535

DanBuxton opened this issue Dec 27, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@DanBuxton
Copy link

Is your feature request related to a problem? Please describe.

By default explicit and dark jokes are returned causing multiple issues asking to remove them. Example issues: #530, #526, #287 etc (https://github.com/Sv443-Network/JokeAPI/issues?q=is%3Aissue+label%3A%22joke+edit%22+in%3Atitle%3A%22remove%22)

Describe the solution you'd like

I believe an opt-in basis would be more ethical and sensible considering the nature of some of these jokes. Instead of safe-mode parameter, allow something like ?safe-mode=false

Perhaps for V3, use ?include=explicit and ?only=explicit,racist etc.

@DanBuxton DanBuxton added the enhancement New feature or request label Dec 27, 2024
@Sv443
Copy link
Member

Sv443 commented Dec 27, 2024

Hi, yes this is something that's already on v3's roadmap.

@Sv443 Sv443 closed this as completed Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants