Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration option to specify Messenger transport #145

Open
loevgaard opened this issue Jun 25, 2019 · 1 comment
Open

Configuration option to specify Messenger transport #145

loevgaard opened this issue Jun 25, 2019 · 1 comment
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). RFC Discussions about potential changes or new features.
Milestone
v1.1.0

Comments

@loevgaard
Copy link
Contributor

loevgaard commented Jun 25, 2019 •
edited
Loading

With the current implementation I have to manually add your commands to the messenger routing config to use an async transport. Instead it would be nice to have a configuration option named transport or something. This transport could then be used to route your messages.

I have done something similar here (although I think it's ugly): https://github.com/Setono/SyliusFragmentTranslationPlugin/blob/master/src/DependencyInjection/SetonoSyliusFragmentTranslationExtension.php#L36-L53
@Zales0123 Zales0123 added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). RFC Discussions about potential changes or new features. labels Jun 25, 2019
@Zales0123 Zales0123 added this to the v1.1.0 milestone Jun 26, 2019
@loevgaard
Copy link
Contributor Author

I am not sure this is the better approach now. I like installation instructions like this: https://github.com/Setono/SyliusFeedPlugin#step-6-using-asynchronous-transport-optional-but-recommended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). RFC Discussions about potential changes or new features.
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
2 participants
@loevgaard @Zales0123