[Api][Checkout][Order] Add tests for accessing order right after completing checkout #11715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Tomanhez
commented
Aug 4, 2020
Tomanhez
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
GSadee
reviewed
Aug 4, 2020
features/checkout/accessing_order_right_after_completing_checkout.feature
Outdated
Show resolved
Hide resolved
|
|
||
| $this->sharedStorage->set( | ||
| 'order_number', | ||
| $this->responseChecker->getValue($this->client->getResponse(), 'number') |
There was a problem hiding this comment.
Is the number not null here? I guess that it should be because the order number is assigned after checkout
There was a problem hiding this comment.
The number is already available here:
Tomanhez
force-pushed
the
order-summary-after-checkout
branch
2 times, most recently
from
b553f9b to
8d96efc
Compare
GSadee
reviewed
Aug 4, 2020
Tomanhez
force-pushed
the
order-summary-after-checkout
branch
from
8d96efc to
6b5bd16
Compare
Tomanhez
force-pushed
the
order-summary-after-checkout
branch
from
6b5bd16 to
3a2492c
Compare
GSadee
approved these changes
Aug 5, 2020
|
Thanks, Tomasz! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.