Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure forward compatibility with ResolveTargetEntityListener #88

Merged

Conversation

teohhanhui
Copy link
Contributor

This should be harmless and will ensure forward compatibility (e.g. when ResolveTargetEntityListener decides to subscribe to another event, however unlikely).

@teohhanhui teohhanhui force-pushed the fix/forward-compat-ResolveTargetEntityListener branch from a472997 to e5959a9 Compare May 24, 2019 16:45
@pamil pamil force-pushed the fix/forward-compat-ResolveTargetEntityListener branch from e5959a9 to 6f6b1cd Compare June 7, 2019 07:10
@pamil pamil changed the base branch from 1.3 to 1.4 June 7, 2019 07:10
@pamil
Copy link
Contributor

pamil commented Jun 7, 2019

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "fix/forward-compat-ResolveTargetEntityListener" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@pamil pamil merged commit 5cf9ef9 into Sylius:1.4 Jun 7, 2019
@pamil
Copy link
Contributor

pamil commented Jun 7, 2019

Thanks, Teoh! 🎉

@teohhanhui teohhanhui deleted the fix/forward-compat-ResolveTargetEntityListener branch June 7, 2019 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants