Reproduce getting the translation repository by its interface use case #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSadee
approved these changes
Sep 11, 2024
|
|
||
| use Sylius\Resource\Model\ResourceInterface; | ||
|
|
||
| interface BookTranslationInterface extends ResourceInterface |
There was a problem hiding this comment.
Suggested change
| interface BookTranslationInterface extends ResourceInterface | |
| interface BookTranslationInterface extends ResourceInterface, TranslationInterface |
There was a problem hiding this comment.
Yes, I've noticed that too. The AbstractTranslation already implements that TranslationInterface, so normally it will not change anything but I could change that to reflect better a real use case.
|
Thank you, Loïc! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 1.12 branch
