fix(core): with method broken for relations (#187)

Syncano · Mar 9, 2018 · a3f645e · a3f645e
1 parent e3741f5
commit a3f645e
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/packages/lib-js-core/src/data.js b/packages/lib-js-core/src/data.js
@@ -119,7 +119,7 @@ class Data extends QueryBuilder {
       const load = new Data(this.instance)
       let ids = references.map(item => item.value)
 
-      ids = Array.isArray(ids[0]) ? ids[0] : ids
+      ids = Array.isArray(ids[0]) ? [].concat.apply([], ids) : ids
 
       if (target === 'user') {
         load._url = `${this._getInstanceURL(

diff --git a/packages/lib-js-core/test/unit/data.js b/packages/lib-js-core/test/unit/data.js
@@ -510,7 +510,15 @@ describe('Data', () => {
             {
               title: 'Awesome post',
               comments: {
-                value: [1, 2],
+                value: [1],
+                type: 'relation',
+                target: 'comment'
+              }
+            },
+            {
+              title: 'Awesome post 2',
+              comments: {
+                value: [2],
                 type: 'relation',
                 target: 'comment'
               }
@@ -531,7 +539,11 @@ describe('Data', () => {
         .should.become([
           {
             title: 'Awesome post',
-            comments: [{id: 1, content: 'Hello'}, {id: 2, content: 'World'}]
+            comments: [{id: 1, content: 'Hello'}]
+          },
+          {
+            title: 'Awesome post 2',
+            comments: [{id: 2, content: 'World'}]
           }
         ])
     })