Cleanup #17
Merged
Cleanup #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kodieg
reviewed
Dec 22, 2020
| for (j, hsh) in self.sparse_matrix_reader.iter_hashes().enumerate() { | ||
| let col_value = ((hash((hsh.value as i64) + (i as i64)) % max_hash) as f32) | ||
| / max_hash_float; | ||
| col.insert(j as usize, col_value); |
There was a problem hiding this comment.
Can we use col.push(col_value) here?
kodieg
approved these changes
Dec 22, 2020
| @@ -41,7 +42,7 @@ fn test_build_graphs_and_create_embeddings() { | |||
| // calculate embeddings in memory | |||
| calculate_embeddings( | |||
| config.clone(), | |||
| sparse_matrix, | |||
| sparse_matrix.clone(), | |||
There was a problem hiding this comment.
maybe Arc::clone(&sparse_matrix) to indicate that this is cheap (though, maybe not)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sparse Matrix refactor (cleanup, simplification, using iter, speedup). Use Cargo.toml data for clap crate.