Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix react native persistence #71

Closed
LucientZ opened this issue Aug 5, 2023 · 2 comments
Closed

Fix react native persistence #71

LucientZ opened this issue Aug 5, 2023 · 2 comments
Assignees
@LucientZ
Labels
bug Something isn't working
Milestone
Sprint 4: HomeDra...

Comments

@LucientZ
Copy link
Collaborator

LucientZ commented Aug 5, 2023 •
edited
Loading

The current version of the app imports the function getReactNativePersistence() from the endpoint "firebase/auth/react-native". This endpoint has been removed recently in firebase 10.0.0, meaning some changes should be made to metro.config.js so that it is instead imported from "react-native".

Refer to:
@LucientZ LucientZ added the bug Something isn't working label Aug 5, 2023
@LucientZ LucientZ self-assigned this Aug 5, 2023
@LucientZ
Copy link
Collaborator Author

LucientZ commented Aug 5, 2023

It looks like persistence is explicitly enabled in this version of the sdk meaning we don't actually have to import getReactNativePersistence() anymore. This means that this can be fixed by just removing the import

@LucientZ
Copy link
Collaborator Author

LucientZ commented Aug 5, 2023

Fixed with 37da7e4

@LucientZ LucientZ closed this as completed Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LucientZ LucientZ

Labels
bug Something isn't working
Projects
SHPE App Development
Status: In-Review
Milestone
Sprint 4: HomeDrawer, Resource Screen...
Development

No branches or pull requests
2 participants
@JasonIsAzn @LucientZ