mGBA Audio Keeps Playing Notes after Rewind

[NarryG]

With the latest developer build, some GBA audio channels appear to not be properly cutting off when using rewind.

Example with Mario & Luigi Superstar Saga
https://streamable.com/lv1f1

This issue does not exist in the latest 0.6.X build of mGBA standalone.

[NarryG]

Tagging @nattthebear as I know he deals with the mGBA core.

[vadosnaprimer]

Updated mgba. Still bugged?

[NarryG]

This commit appears to have actually broken the core completely

[NarryG]

The issue still persists @vadosnaprimer
I've compared against mGBA 0.6.3 stable and the issue appears to be upstream. I'll report it there. I must have made a mistake when I originally said it wasn't happening in standalone

[nattthebear]

Why did we revert the palette changes? What's going on here?

[vadosnaprimer]

It was only reverted in my 1.x-only fork. tasvideos/mgba is fine, and it's what I used to build our current mgba.dll. I just accidentally used my 1.x build here initially.

[NarryG]

The issue has been fixed upstream in the 0.7 branch. I requested endrift backport to 0.6.X
mgba-emu/mgba#1107

[NarryG]

It has been backported so it's now just a matter of updating the fork again.

[vadosnaprimer]

Test
https://yadi.sk/d/nAbEFtVr3XZPDh