Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain effects become entire screen flashes when hq2x is enabled #2196

Closed
ghost opened this issue Jul 4, 2020 · 12 comments
Closed

Certain effects become entire screen flashes when hq2x is enabled #2196

ghost opened this issue Jul 4, 2020 · 12 comments

Comments

@ghost
Copy link

ghost commented Jul 4, 2020

OK so
Sega Genesis Altered Beast.

load game and fast forward to third attract mode. (level 2 with dragons)

in version 2.4.2 no problem. OGL and DX work perfect here

Latest AppVeyor build in Direct X mode no problem.

Latest appveyor Build in OpenGL problem, Every time dragon fires screen flashes.

This will happen if you reach level 2 or if you allow the game to demo level 2 which is every 3rd demo and you can fast forward to get there.

Was able to replicate on 3 systems with 3 different video cards, Nvidia, Intel and AMD

Something has either changed with OGL or with Genesis Plus GX in latest dev builds. I can make this occur 100% of the time on dev and 0 times on 2.4.2

(author's username was @jjfmz42015)

@ghost
Copy link
Author

ghost commented Jul 4, 2020

not just altered beast, happens 100% of time during game play if in OGL mode on Twin Cobra.

Note 2.4.2 also plays this proper. Dev builds only, OpenGL only

@ghost ghost changed the title Altered Beast Sega Genesis bug in latest builds Sega Genesis bug in latest builds opengl flash Jul 4, 2020
@ghost
Copy link
Author

ghost commented Jul 4, 2020

happens with many more games

@nattthebear
Copy link
Contributor

I can't reproduce this.

@nattthebear nattthebear removed their assignment Jul 4, 2020
@YoshiRulz
Copy link
Member

@jjfmz42015 You'd linked the first broken commit, why did you remove it? Did you bisect properly?

@ghost
Copy link
Author

ghost commented Jul 4, 2020

@jjfmz42015 You'd linked the first broken commit, why did you remove it? Did you bisect properly?

Because the last commit i thought was good does this intermittently. Still have not reproduced under 2.4.2 but still producing with dev builds. I will test more and try to find the exact build it starts from, then I will record videos of proper vs what Im noticing.

@ghost
Copy link
Author

ghost commented Jul 4, 2020

I can't reproduce this.

Try loading the a second genesis game. Seems sometimes it happens and sometimes it doesn’t until you load a second game.

I will see if I can somehow narrow down better. Already tried on multiple video cards on multiple systems so I know its not a video driver issue and that it will happen on other machines.

Will update this topic soon. Will test more

@ghost
Copy link
Author

ghost commented Jul 5, 2020

ok guys.

with this rom
Twin Cobra (U) [!]
SHA1:C386C617703A3F5278D24B310C6BC15E3E180BDF
MD5:0006C0C0DB9B334B79F1ED20EEB8B9BF

under opengl and hq2x I am able to replicate 100% of the time during gameplay

With version 2.4.2 under ogen gl and hq2x it works perfect.

@nattthebear @YoshiRulz

also with many other games. if you try again ogl+hq2x you will see it for sure.

@ghost
Copy link
Author

ghost commented Jul 5, 2020

hmmm actually happens on all cores not just sega.

so if opengl and hq2x many games either flash or seem to cycle through colors.

a few builds back hq2x was broken and i guess its fix is partial

@ghost ghost changed the title Sega Genesis bug in latest builds opengl flash bug in latest builds opengl + hq2x flash Jul 5, 2020
@ghost
Copy link
Author

ghost commented Jul 5, 2020

the problem stars since this fix #2160

@ghost ghost changed the title bug in latest builds opengl + hq2x flash bug in latest builds opengl + hq2x flash (caused by fix from #2160) Jul 5, 2020
@YoshiRulz YoshiRulz added App: EmuHawk Relating to EmuHawk frontend and removed Core: Genplus-gx Sega Genesis / Mega Drive core labels Jul 5, 2020
@zeromus
Copy link
Contributor

zeromus commented Jul 5, 2020

Find a game to test that doesn't require having to play to level 2

@ghost
Copy link
Author

ghost commented Jul 5, 2020

Find a game to test that doesn't require having to play to level 2

Try twin cobra sega genesis

@ghost
Copy link
Author

ghost commented Jul 5, 2020

This game should show the problem the second you start level 1

@zeromus zeromus closed this as completed in ae763f2 Jul 5, 2020
@YoshiRulz YoshiRulz added the Ghost'd OP's username has been lost to time label Aug 9, 2024
@YoshiRulz YoshiRulz changed the title bug in latest builds opengl + hq2x flash (caused by fix from #2160) Certain effects become entire screen flashes when hq2x is enabled Aug 9, 2024
@YoshiRulz YoshiRulz added Ghost'd OP's username has been lost to time and removed Ghost'd OP's username has been lost to time labels Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants