From 3f3da1fb1394bf674764d0cf6607111e190da2ee Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Mon, 6 Jan 2025 20:09:09 +0000 Subject: [PATCH 1/2] [pre-commit.ci] pre-commit autoupdate MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit updates: - [github.com/astral-sh/ruff-pre-commit: v0.6.9 → v0.8.6](https://github.com/astral-sh/ruff-pre-commit/compare/v0.6.9...v0.8.6) - [github.com/pre-commit/mirrors-mypy: v1.11.2 → v1.14.1](https://github.com/pre-commit/mirrors-mypy/compare/v1.11.2...v1.14.1) --- .pre-commit-config.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 018355c..a5f845e 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -1,7 +1,7 @@ repos: # This should be before any formatting hooks like isort - repo: https://github.com/astral-sh/ruff-pre-commit - rev: "v0.6.9" + rev: "v0.8.6" hooks: - id: ruff args: ["--fix"] @@ -28,7 +28,7 @@ repos: - id: mixed-line-ending exclude: ".*(.fits|.fts|.fit|.header|.txt|tca.*)$" - repo: https://github.com/pre-commit/mirrors-mypy - rev: "v1.11.2" + rev: "v1.14.1" hooks: - id: mypy additional_dependencies: [ "types-setuptools" ] From 931eec1d1dad7dd951d84b84258b97e25de14b56 Mon Sep 17 00:00:00 2001 From: Shane Maloney Date: Mon, 10 Feb 2025 14:20:48 +0000 Subject: [PATCH 2/2] Fix bug found by updated mypy --- xrayvision/visibility.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xrayvision/visibility.py b/xrayvision/visibility.py index 9e650dc..ca9698f 100644 --- a/xrayvision/visibility.py +++ b/xrayvision/visibility.py @@ -300,7 +300,7 @@ def __init__( if phase is not None: data[self._phase_key] = (dims, phase.value.to_value(visibilities.unit)) units[self._phase_key] = phase.unit - if phase_uncertainty is not None: + if phase_uncertainty is not None and phase is not None: data[self._phase_uncert_key] = (dims, phase_uncertainty.to_value(phase.unit)) if meta is None: meta = VisMeta()