[#191] refactor(TicketService): findBookings 메서드 분리, 오래된 예매취소내역 삭제 시간 변경

TEAM-BEAT · Aug 29, 2024 · 16d1770 · 16d1770
1 parent 68674c2
commit 16d1770
Showing 1 changed file with 14 additions and 12 deletions.
diff --git a/src/main/java/com/beat/domain/booking/application/TicketService.java b/src/main/java/com/beat/domain/booking/application/TicketService.java
@@ -52,17 +52,7 @@ public TicketRetrieveResponse getTickets(Long memberId, Long performanceId, Sche
         Performance performance = performanceRepository.findById(performanceId)
                 .orElseThrow(() -> new NotFoundException(PerformanceErrorCode.PERFORMANCE_NOT_FOUND));
 
-        List<Booking> bookings;
-
-        if (scheduleNumber != null && bookingStatus != null) {
-            bookings = ticketRepository.findBySchedulePerformanceIdAndScheduleScheduleNumberAndBookingStatus(performanceId, scheduleNumber, bookingStatus);
-        } else if (scheduleNumber != null) {
-            bookings = ticketRepository.findBySchedulePerformanceIdAndScheduleScheduleNumber(performanceId, scheduleNumber);
-        } else if (bookingStatus != null) {
-            bookings = ticketRepository.findBySchedulePerformanceIdAndBookingStatus(performanceId, bookingStatus);
-        } else {
-            bookings = ticketRepository.findBySchedulePerformanceId(performanceId);
-        }
+        List<Booking> bookings = findBookings(performanceId, scheduleNumber, bookingStatus);
 
         List<TicketDetail> bookingList = bookings.stream()
                 .map(booking -> TicketDetail.of(
@@ -84,6 +74,18 @@ public TicketRetrieveResponse getTickets(Long memberId, Long performanceId, Sche
         );
     }
 
+    private List<Booking> findBookings(Long performanceId, ScheduleNumber scheduleNumber, BookingStatus bookingStatus) {
+        if (scheduleNumber != null && bookingStatus != null) {
+            return ticketRepository.findBySchedulePerformanceIdAndScheduleScheduleNumberAndBookingStatus(performanceId, scheduleNumber, bookingStatus);
+        } else if (scheduleNumber != null) {
+            return ticketRepository.findBySchedulePerformanceIdAndScheduleScheduleNumber(performanceId, scheduleNumber);
+        } else if (bookingStatus != null) {
+            return ticketRepository.findBySchedulePerformanceIdAndBookingStatus(performanceId, bookingStatus);
+        } else {
+            return ticketRepository.findBySchedulePerformanceId(performanceId);
+        }
+    }
+
     @Transactional
     public void updateTickets(Long memberId, TicketUpdateRequest request) {
         Member member = memberRepository.findById(memberId).orElseThrow(
@@ -144,7 +146,7 @@ public void cancelTickets(Long memberId, TicketCancelRequest ticketCancelRequest
         }
     }
 
-    @Scheduled(cron = "0 0 0 * * ?")
+    @Scheduled(cron = "0 0 4 * * ?")
     @Transactional
     public void deleteOldCancelledBookings() {
         LocalDateTime oneYearAgo = LocalDateTime.now().minusYears(1);