[#172] refactor(PromotionService): checkAndDeleteInvalidPromotions 성능…

… 및 확장성 고려한 refactor
TEAM-BEAT · Aug 16, 2024 · 94bf32b · 94bf32b
1 parent 7d88deb
commit 94bf32b
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/src/main/java/com/beat/domain/promotion/application/PromotionService.java b/src/main/java/com/beat/domain/promotion/application/PromotionService.java
@@ -27,16 +27,17 @@ public void checkAndDeleteInvalidPromotions() {
         List<Promotion> promotions = promotionRepository.findAll();
 
         for (Promotion promotion : promotions) {
-            if (promotion.getPerformance() != null) {
-                Performance performance = promotion.getPerformance();
+            Performance performance = promotion.getPerformance();
 
-                List<Schedule> schedules = scheduleRepository.findByPerformanceId(performance.getId());
-                int minDueDate = scheduleService.getMinDueDate(schedules);
+            if (performance == null) {
+                return;
+            }
+
+            List<Schedule> schedules = scheduleRepository.findByPerformanceId(performance.getId());
+            int minDueDate = scheduleService.getMinDueDate(schedules);
 
-                // MinDueDate가 음수일 경우 Promotion 삭제
-                if (minDueDate < 0) {
-                    promotionRepository.delete(promotion);
-                }
+            if (minDueDate < 0) {
+                promotionRepository.delete(promotion);
             }
         }
     }