Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM support for app_rtsp_sip #313

Closed
tommyjlong opened this issue Mar 10, 2024 · 4 comments
Closed

ARM support for app_rtsp_sip #313

tommyjlong opened this issue Mar 10, 2024 · 4 comments

Comments

@tommyjlong
Copy link

Hi @felipecrs
I see you just added a patch to include a couple of #defines for the app_rtsp_sip.c for ARM based builds.
Just checking in to see if these built OK.

A couple of things too:
Here it was mentioned that the builds failed on:
aarch64, armhf and armv7
but looks like the build dependency is arm*; maybe need to add aarch64?

When I was working on this problem back in 2022, I also added a third #define
#define ARM
I'm not sure why, but if the arm architectures build without it, then probably OK to leave it out.

@felipecrs
Copy link
Collaborator

The compilation worked fine for all the three ARM platforms, but I did not test yet.

@felipecrs
Copy link
Collaborator

felipecrs commented Mar 10, 2024

Btw TARGETARCH should be arm64 rather than aarch64, that's why arm*.

@tommyjlong
Copy link
Author

Good to hear!

@felipecrs
Copy link
Collaborator

felipecrs commented Mar 10, 2024

v4.2.0 is to be released soon and should include it (@los93sol is also waiting for it - #311)

BTW I'm dropping support for armhf (#315), please chime in if you have any concern.

I'm closing this issue, but there's no problem to continue discussing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants