Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation #24

Open
serbinsh opened this issue Apr 3, 2023 · 2 comments
Open

Improve documentation #24

serbinsh opened this issue Apr 3, 2023 · 2 comments
Assignees

Comments

@serbinsh
Copy link
Member

serbinsh commented Apr 3, 2023

I have been using the package to create some idealized response surfaces and I realized that the documentation isnt complete. For example for many of the functions the output of the function isnt documented. That is the data columns/outputs and units

I also noted that its not always clear if we are using different models for gs etc if they are assuming the model-specific units for g0 etc or a standard unit that then gets converted in the function, as needed.

@JulienLamour
Copy link
Member

Sorry if that's not clear. The units are always mol m-2 s-1 in the conductance models. I think this is detailed in the help of the f.make.param function.

@JulienLamour
Copy link
Member

This is also detailed in the help of the f.gs function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants