Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing multiple URLS has no effect #180

Closed
mhnsn opened this issue Dec 22, 2020 · 2 comments · Fixed by #184
Closed

Passing multiple URLS has no effect #180

mhnsn opened this issue Dec 22, 2020 · 2 comments · Fixed by #184
Assignees

Comments

@mhnsn
Copy link

mhnsn commented Dec 22, 2020

Describe the bug
A clear and concise description of what the bug is.
Passing either a space-delimited or comma-delimited list of URLS causes the app to only run against the first site.

To Reproduce
Steps to reproduce the behavior:

  1. npx auto-lighthouse -u <URL_1> <URL_2>
  2. ???
  3. Profit.

Expected behavior
Passing multiple websites as an arg should cause each site to be tested.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome.
  • Version Latest

Additional context
Running in PowerShell

@TGiles
Copy link
Owner

TGiles commented Dec 23, 2020

Hi mhnsn, thanks for filing this! I'll look into reproducing this and see why this is happening. While I reproduce, can you tell me your node version as well? I don't believe it's a node version issue, but it might be useful if I'm unable to reproduce the issue.

@TGiles
Copy link
Owner

TGiles commented Dec 23, 2020

@mhnsn don't worry about the repro, apparently I forgot to use the variadic arguments in commander.js this whole time 😅

Thanks again for filing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants