Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of backend module icons #1

Open
3 tasks done
typecat opened this issue Mar 20, 2021 · 2 comments
Open
3 tasks done

Refactoring of backend module icons #1

typecat opened this issue Mar 20, 2021 · 2 comments
Assignees

Comments

@typecat
Copy link

typecat commented Mar 20, 2021

He have to remove this task, the module bar is outside our scope and will be handle by the UX Initiative team.

According to the mockup the module icons in the module bar should be mono-chome (black-and-white). The icons are fetched from the TYPO3 icons repository which makes it difficult to apply changes without them either being overridden or creating a new version in the icons repository.

Dealing with the icons we also discovered, that they need to be refactored more detailed than just changing the colors. Some icons are used for more purposes than just the module bar (e.g. dashboard,redirects, reports), other icons need to be simplified in the drawing instructions. Currently these are not consistent: outline and blank space vs. stacked shapes and fills.

For proof of concept a hotfix in the Gruntfile.js was implemented, which of course needs to be removed when creating a PR, so that the icons could be changed directly in the Resources/Public/Icons directory of the corresponding extensions.

TODO:

  • Create a concept for module icons
  • Refactor the icons in the icons repository and create a version for TYPO3 11
  • Use new icons version in TYPO3 11 and remove the hotfix (631cb52)

Mockup:
01-module-bar-page-tree-bar

Rachel > finally we handled thing with CSS we don't need anymore to change the icons

@typecat
Copy link
Author

typecat commented Apr 14, 2021

Just found out that module group icons are done differently: they use fill="currentColor" instead of a fixed color code. This should be done for module icons as well. This way, the icon color gets automatically inverted without applying an additional inversion filter in CSS.

@typecat
Copy link
Author

typecat commented Apr 28, 2021

The hotfix (631cb52) is removed btw, we put a greyscale on the icons instead. This way there would be no color flashing for if a third party module is installed.
The remaining thing to do would be to remove the background in the icon repository.

@rfoucard rfoucard changed the title Refactor backend module icons Remove the Refactoring of backend module icons Jul 18, 2021
@rfoucard rfoucard changed the title Remove the Refactoring of backend module icons Refactoring of backend module icons Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants