-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++ API #5
Comments
Be careful with the resource class, as there is already an Horde3D::Resource class declared here: I would suggest going for something else or hide the horde3d implementation completely, as that might create confusion. Also, in your Resource class I do not like the redundancy of the names such as GetResourceType() or GetResourceName(). They are both member functions of the Resource class, thus the Resource in the names can be avoided. |
The idea is to hide the horde3D implementation completely, so you would not be able to access any of those internal classes. As for the redundancy, you're right but at the same time we might clash with stuff such as Textures which might require a GetType method (and then it would be a redundant GetTextureType), so it's a matter of tradeoff there, we need to decide whether it's worth renaming it to something else |
In the first case, it might be worth creating a new namespace. Thus, decide a name for the middleware and be consistent with it. |
Yep, of course. The API is there just to give the general idea, we should find a name for the "new" engine and make a namespace as well. I guess we can change the GetResourceType to GetType and so on, we'll find a solution for specific problems such as the Texture one later on. |
GIST Here:
https://gist.github.com/subr3v/09e82199c9d93e986623
The text was updated successfully, but these errors were encountered: