Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Regression: Pressing 'enter' closes the "Add Tags" window #683

Closed
3 tasks done
Tishj opened this issue Jan 4, 2025 · 4 comments · Fixed by #685
Closed
3 tasks done

[Bug]: Regression: Pressing 'enter' closes the "Add Tags" window #683

Tishj opened this issue Jan 4, 2025 · 4 comments · Fixed by #685
Labels
Priority: Medium An issue that shouldn't be be saved for last Type: Bug Something isn't working as intended Type: QoL A quality of life (QoL) enhancement or suggestion Type: UI/UX User interface and/or user experience
Milestone

Comments

@Tishj
Copy link

Tishj commented Jan 4, 2025

Checklist

  • I am using an up-to-date version.
  • I have read the documentation.
  • I have searched existing issues.

TagStudio Version

Alpha 9.5

Operating System & Version

Windows 10

Description

Previously, when adding tags to an entry, pressing 'enter' would add the tag, but keep the window open.
Pressing 'enter' a second time while the field was empty would then close the window.

Now the window closes on the first enter, which makes it a lot more tedious to add multiple tags to an entry.

@Tishj Tishj added the Type: Bug Something isn't working as intended label Jan 4, 2025
@SkeleyM
Copy link
Contributor

SkeleyM commented Jan 5, 2025

oops, this regression was introduced in a previous commit i had done. i was unaware this was intended behaviour as i was still getting used to this program.

id be happy to work on this and submit a quick pr

@Tishj
Copy link
Author

Tishj commented Jan 5, 2025

I'm not sure this was intended behavior, but I quite liked the behavior and have come to rely on it 😅
In case a maintainer weighs in and says this wasn't intended behavior, perhaps a compromise could be to let shift+enter keep the window open instead? (I'd prefer the old behavior though)

@SkeleyM
Copy link
Contributor

SkeleyM commented Jan 5, 2025

i see pro's on both sides of the coin but I suppose its up to the maintainers if its correct or not, however I do like your compromise and id be happy to implement it if it comes to that.

in the mean time you could clone my branch which has this feature in it
"git clone -b fix_my_regression https://github.com/SkeleyM/TagStudio.git"

@Computerdores
Copy link
Collaborator

Previously, when adding tags to an entry, pressing 'enter' would add the tag, but keep the window open.
Pressing 'enter' a second time while the field was empty would then close the window.

I can confirm that this was intended behaviour.

@CyanVoxel CyanVoxel added Type: QoL A quality of life (QoL) enhancement or suggestion Type: UI/UX User interface and/or user experience Priority: Medium An issue that shouldn't be be saved for last labels Jan 6, 2025
@CyanVoxel CyanVoxel moved this to 🚧 In progress in TagStudio Development Jan 6, 2025
@CyanVoxel CyanVoxel added this to the SQL Parity milestone Jan 6, 2025
@github-project-automation github-project-automation bot moved this from 🚧 In progress to ✅ Done in TagStudio Development Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium An issue that shouldn't be be saved for last Type: Bug Something isn't working as intended Type: QoL A quality of life (QoL) enhancement or suggestion Type: UI/UX User interface and/or user experience
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

4 participants