Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selectedFlatRows keeps changing, triggering effects dependent on it #1740

Closed
burtyish opened this issue Dec 9, 2019 · 1 comment
Closed

Comments

@burtyish
Copy link

burtyish commented Dec 9, 2019

Describe the bug
selectedFlatRows keeps changing, triggering effects dependent on it.

To Reproduce
Set up an effect dependent on selectedFlatRows. See codesandbox below.

Expected behavior
selectedFlatRows should only change when row selection changes.

Codesandbox!
In the codesandbox below, open the console and then switch the version of react-table from beta.16 to rc.5.
You will see endless logging and eventually reach maximum callstack.
https://codesandbox.io/s/zealous-moore-7zxyr

Screenshots
N/A

Desktop (please complete the following information):

  • OS: MacOS
  • Browser: Chrome
    react-table version rc.5

Additional context
Add any other context about the problem here.

P.S.
Possibly related to #1739?

@tannerlinsley
Copy link
Collaborator

Make sure you're using the latest release candidate version of React Table. This issue was solved in a version after the one you are using. If you keep having issues, please comment to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants