Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vue table] support for reactivity in Vue-adapter in version 8.20 broke reactive for the old getter get data() style #5701

Closed
2 tasks done
ttphi88 opened this issue Aug 9, 2024 · 1 comment · Fixed by #5702

Comments

@ttphi88
Copy link

ttphi88 commented Aug 9, 2024

TanStack Table version

8.20.3

Framework/Library version

vue 3.4.31

Describe the bug and the steps to reproduce it

Steps to reproduce: (see the provided codesandbox)

  1. Go to the basic example: https://tanstack.com/table/latest/docs/framework/vue/examples/basic
  2. Replace the rerender function with this code:
const rerender = () => {
  data.value = [{
    firstName: 'tanner',
    lastName: 'linsley',
    age: 24,
    visits: 100,
    status: 'In Relationship',
    progress: 50,
  }]
}
  1. Click on the "Rerender" button, and notice the table does not update.

It works as expected if I pass the data ref into the useVueTable option.

const table = useVueTable({
  data: data, // <= updated
  columns,
  getCoreRowModel: getCoreRowModel(),
})

Your Minimal, Reproducible Example - (Sandbox Highly Recommended)

https://codesandbox.io/p/devbox/competent-khayyam-lstt95?file=%2Fsrc%2FApp.vue

Screenshots or Videos (Optional)

No response

Do you intend to try to help solve this bug with your own PR?

No, because I do not know how

Terms & Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
@KevinVandy
Copy link
Member

@OlaAlsaker it's looking like it does not work exactly as before with the additional functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants