Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"NaN" in ingrediant list #1463

Closed
Torsten- opened this issue Feb 1, 2022 · 8 comments
Closed

"NaN" in ingrediant list #1463

Torsten- opened this issue Feb 1, 2022 · 8 comments
Labels
question Further information is requested

Comments

@Torsten-
Copy link

Torsten- commented Feb 1, 2022

Hi,

I'v just set up a new installation with docker compose.
After adding a recipe (manual) and adding ingrediants I just get "NaN":

grafik

If I edit the recipe the ingrediants are all correct:

grafik

I've also imported recipes from chefkoch.de - there everything is fine.

@vabene1111
Copy link
Collaborator

can you export that recipe and post it here so that i can test if i can reproduce the issue ?

@vabene1111 vabene1111 added the question Further information is requested label Feb 3, 2022
@Torsten-
Copy link
Author

Torsten- commented Feb 3, 2022

Sure, here it is.
export.zip

@vabene1111
Copy link
Collaborator

thanks for your recipe. The problem is actually that your recipe has 0 servings. This of course should not be possible but i have pushed a fix so its gone fore the next version. What you can easily do to fix your problem is just set the servings to "1" or similar.

thanks for reporting and providing the export for quick debugging

@smilerz
Copy link
Collaborator

smilerz commented Feb 4, 2022

you can also 'Disable Amount' via the ingredient context menu

@Torsten-
Copy link
Author

Torsten- commented Feb 5, 2022

Thanks for the quick fix.
I found the problem: I did type in an amount. I typed in 0,4 as amount servings an "L" as text (so 0,4 liter). But it seems that the amount needs to be an integer and can't be a float?
I've just tested with the newest "latest" docker container right now, neither 0,4 nor 0.4 does work - it gets reset to 0 ervery time.

I'll just set it to 1, but maybe this is another little bit to fix ;-)

@vabene1111
Copy link
Collaborator

yea i screwed that up, i implemented a "quick fix" that simply checks for servings to be a proper float and if its not it sets it to 0 (which is stupid). It now sets it to 1 and if its 0 it sets it to 1 as well.

@Torsten-
Copy link
Author

Torsten- commented Feb 5, 2022

ok, but should it gernerally be possible to enter decimal values / floats or is this filed meant to be just an integer?

@vabene1111
Copy link
Collaborator

i think you should be able to enter floats. i have never done so i must admit .. but maybe the model is also an integer, would need to look that up but on the move right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants