Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to Display Only the All Ingredients #2266

Closed
srwareham opened this issue Jan 11, 2023 · 8 comments
Closed

Option to Display Only the All Ingredients #2266

srwareham opened this issue Jan 11, 2023 · 8 comments
Labels
enhancement New feature or request

Comments

@srwareham
Copy link
Contributor

srwareham commented Jan 11, 2023

Is your feature request related to a problem? Please describe.

For simple recipes, it would be great to have the option to only show the top-of-page Ingredients list without needing to display step-level ingredients.

Here is what Tandoor looks like with default settings. Recipe information is redundant and takes up more space than needed.
image

Here is what Tandoor looks like with "Display a list of all ingredients at the start of the recipe" unchecked. Less space is used than the above, however, the horizontal space next to the image is wasted. In my opinion , it's not aesthetically the best either. Relatedly, in this example and I think in most single-dish recipes, the ingredients don't logically "belong" to the first step so it's a bit visually jarring.
image

Describe the solution you'd like

It would be great to have the option for ingredients to be displayed only at the recipe level. Here's a proposed mock below using this same example. I'd love to be able to see the ingredients sharing the same horizontal space as the image without needing to duplicate them again in the recipe steps.
image

Describe alternatives you've considered

It's not clear to me whether this would require any data model changes. If those are prohibitively complex, one band aid fix could be automatically creating a step 0 to contain a "gather ingredients" step. There could be an "Additional Options" setting to not display this step.

Thank you for the great product!

Additional context

No response

@srwareham srwareham added the enhancement New feature or request label Jan 11, 2023
@TheGor1lla
Copy link

I'd also be interested in this feature.
Personally having the ingredients seperated from the steps could be a default

@mtik00
Copy link

mtik00 commented Jan 23, 2023

I've been trying to find various workarounds in the UI for this behavior (I'm new to Tandoor), but I've not found one. Having the ability to disconnect the ingredient list from Step 1 would be great. Not sure if this would be easier, but "hidden" steps could be something the serializer might be able to handle.

This is closely related to #1325 and #1293

@rourke
Copy link

rourke commented Jan 23, 2023

I don't quite understand the logic behind the way it's currently working in Tandoor. The step description holds the information on what to do with what ingredients. Why add the ingredients to the step again? The solution you proposed here is how all the recipe tools, recipe sites and cookbooks I know do it.

@smilerz
Copy link
Collaborator

smilerz commented Jan 23, 2023

I don't quite understand the logic behind the way it's currently working in Tandoor. The step description holds the information on what to do with what ingredients. Why add the ingredients to the step again? The solution you proposed here is how all the recipe tools, recipe sites and cookbooks I know do it.

I don't understand your confusion - Tandoor isn't adding ingredients to the step again. There is a summary of all ingredients at the top - if you have multiple steps with ingredients then the ingredients are displayed with the step.

@rourke
Copy link

rourke commented Jan 23, 2023

I don't quite understand the logic behind the way it's currently working in Tandoor. The step description holds the information on what to do with what ingredients. Why add the ingredients to the step again? The solution you proposed here is how all the recipe tools, recipe sites and cookbooks I know do it.

I don't understand your confusion - Tandoor isn't adding ingredients to the step again. There is a summary of all ingredients at the top - if you have multiple steps with ingredients then the ingredients are displayed with the step.

I mean why it visually looks like this, not necessarily how it works technically. But even technically speaking it makes more sense to me to have 1 list of ingredients on recipe level, and optionally reference those ingredients on step level in a separate list.

But I don't understand the benefit of having a list of ingredients on step level. I've just never seen a recipe that does that.

@smilerz
Copy link
Collaborator

smilerz commented Jan 24, 2023

I mean why it visually looks like this, not necessarily how it works technically. But even technically speaking it makes more sense to me to have 1 list of ingredients on recipe level, and optionally reference those ingredients on step level in a separate list.

But I don't understand the benefit of having a list of ingredients on step level. I've just never seen a recipe that does that.

Visually, it doesn't look any different on mobile - which is likely why this hasn't come up before.

But, technically, there are lots of recipes that have multiple steps that require different sets of ingredients. Bakery, dishes with sauces or stocks, marinades, rubs, brines, etc, etc, etc.

@smilerz smilerz closed this as completed Jan 24, 2023
@smilerz smilerz reopened this Jan 24, 2023
@tekjoey
Copy link

tekjoey commented Jun 8, 2023

+1 for this change. This is honestly the only reason why I am still using Mealie. I agree with @rourke and @srwareham, for most of my recipes the per-step ingredient list is redundant. I totally understand that some people want/need the granularity of per-step ingredients, but as @rourke said, most recipes I find online don't automatically do this, so I think that Tandor's default behavior should mirror them.

@srwareham
Copy link
Contributor Author

Feature has been merged! #2539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants