-
-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Add Support for OAuth #230
Comments
i like the idea. Probably not something that is super easy to do but definitly something i want to take a look at in the future |
Another vote for Keycloak integration. I'm planning to replace my current DokuWiki recipe site with this project. It's not a must-have feature, but would be nice to have. Here are a couple links on adding OAuth2 and Keycloak to Django projects: https://www.toptal.com/django/integrate-oauth-2-into-django-drf-back-end |
thanks for the request. These are features i would definitely like to add in the future but will probably not be around for a while as many other (more requested) features are the priority and my time is a little sparse ... |
That makes sense. Thanks for the great work so far. |
My opinion is that SSO is a MUST in today's self hosting environment. Family, parents, friends, have an account in my setup and if the application doesn't support it, usually I go with something that allows me to connect to keycloak or find an alternative solution/workaround to get the job done. This might change soon, when Nginx Proxy Manager gets OIDC access list. This will allow me to add applications as a single user and restrict the site to authenticated users. Time will tell, but I would definitely would like to see SSO implemented for recipies. |
thanks for the feedback 👍 There is already support for proxy authentication (like authelia) which i guess could be integrated with any SSO but OAuth and possible other providers are definitly something i want to add |
maybe something to look at (I also use it for some projects already): https://github.com/pennersr/django-allauth easy to implement and configure. and around auth it actually provides everything important |
thank you very much, i had hoped that there would be an easy to use django auth plugin to use for integration 👍 |
Ok i have implemented basic support for Oauth on the new Several things still need to be done
|
Ok so i have implemented django allauth (which was not to hard) and were able to disable signup. Now i myself do not use a central authentication system for my self hosted systems so i dont really now your requirements. Because of this i have same questions:
I currently see two options but maybe there is a better way of doing it
|
The way it works, signup is disabled on the recipes site. |
This definitely makes sense if you use an identiyprovider like keycloak where only trusted people even have accounts. Since allauth also supports github, google etc. i will need to either disable those or find a way that those users dont get any rights when they sign up 🤔 but ok, you have already helped me a lot ! |
Allauth support was added with the latest beta and will be included in the next release. se the docs for more information. It would be a great help if someone could spin up a beta instance and test if it works with their setup. Image should be released in half an hour or so |
Hey, I just tested the beta image and it works great with Keycloak. I had some hiccups during the setup. The example.com site did not exist at the beginning and I ran into an internal server error after deleting it. Unfortunately, I did not save the logs. But it is working great now. Thanks! |
perfect, if you feel like anything is missing in the docs or unintuitive let me know |
Bit of a luxury request, but also similar to ticket #88
Would it be possible to implement support for OAuth based authentication? This would allow users to centralise their user management using something like Keycloak. Preventing the mismatching of passwords and alike, also this would allow keycloak to handle additional account hardening such as Multi Factor Authentication.
The text was updated successfully, but these errors were encountered: