Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report - Meal Plan on Sundays not saving #231

Closed
dwtaylornz opened this issue Nov 15, 2020 · 4 comments
Closed

Bug Report - Meal Plan on Sundays not saving #231

dwtaylornz opened this issue Nov 15, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@dwtaylornz
Copy link

Version

Please provide your current version (can be found on the system page since v0.8.4)
Current Version: 0.11.1

Bug description

Meals dragged onto a meal plan on a Sunday do not save, also If i drag meal onto any Sunday (future) it does not save.
Every other day )mon - sat) saves without issue.

@sebimarkgraf
Copy link
Contributor

Hey @dwtaylornz
I guess I am having the same bug as you. But since I am using different devices it seems to be caused by the language settings.

Could you confirm if sunday is the first day in your week?

Using any language setting that moves the sunday as last day in the week works without problems for me, but e.g. en-us seems to have problems.

@vabene1111
Copy link
Collaborator

ah thats an interesting thing because i was not able to reproduce this and this would explain it. Will take a look at this hopefully soon

@vabene1111 vabene1111 added the bug Something isn't working label Nov 28, 2020
@dwtaylornz
Copy link
Author

Hey @dwtaylornz
I guess I am having the same bug as you. But since I am using different devices it seems to be caused by the language settings.

Could you confirm if sunday is the first day in your week?

Hmm, Monday is the official first day of the week here in New Zealand.
I'll have a play with language settings to see if that has any effect.

@vabene1111
Copy link
Collaborator

vabene1111 commented Dec 14, 2020

yes this is definitly related to the locale. If sunday is the first day of the week saving the entry fails.

EDIT: specifically while the client uses localized weeks (starting with whatever is local) the server uses a default week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants