Unable to import recipe from JSON source #2426
Comments
|
its something that usually comes with a recipe when its imported, need to implement a check if it comes from json so its not requested. thanks for the good report |
|
I can see in the release notes for v1.4.12 a mention of a fix for an issue that sounds similar to this, does that mean this is fixed? |
|
yes, i just did not see that this issue exists, thansk for pointing it out. |
|
@vabene1111 I just updated to v1.5.0 and using the same JSON recipe as the initial report now fails with a different error message. There's no traceback, and the {"name":["This field may not be blank."]}Is this just a new message for the same issue or a new problem? EDIT: I've tested a bit more and the same JSON recipe will fail to import when imported using the Import Recipe -> Source option, but will work when added to a ZIP and imported using the "Nextcloud Cookbooks" import type. |
|
intersting, i dont get an error but it does not load any data from your json, need to take a look at that, might have changed something that broke this again. |
|
i am not sure exactly but i can import this json without any problems need to look into why yours above is not working but in the end we likely need to fix this in because we use their text scraper and it does not return anything on your input https://github.com/hhursev/recipe-scrapers |
|
ok its your json is missing the line, I will an additonal check to add this exact type hint if nothign is given since this should be everything people post to the endpoint anyway. |
|
Oh that's a good spot, I didn't even think of the top-level schema specification, but adding that does import perfectly. |
|
auto adding these in the next release |
Tandoor Version
1.4.8
Setup
Docker / Docker-Compose
Reverse Proxy
Traefik
Other
No response
Bug description
Attempting to import a recipe with the following JSON results in an error, although the recipe seems to be well-formed from a check agains the JSON Recipe schema on schema.org. The import is being attempted from the Source tab of the Import Recipe page.
Recipe JSON
{ "name": "Easy Smoked Salmon Sushi Bowl", "description": "Looking for dinner on the table quick smart? These fast recipes are ready in 25 minutes or less and all come with yumness guaranteed.", "totalTime": "PT0H25M0S", "recipeCategory": "fish", "keywords": [ ], "recipeIngredient": [ "1 spring onion", "1 carrot", "150g jasmine rice", "1 avocado", "100g smoked salmon slices", "40g Japanese dressing", "1 garlic clove", "1 tsp white vinegar", "1 tsp sugar", "2 eggs" ], "recipeInstructions": [ { "text": "Check your avocado is ripe before starting this recipe (see Kitchen hack). Thinly slice 1 garlic clove. Thinly slice the spring onion. Peel the carrot into ribbons with a vegetable peeler.\n", "name": "Prep ingredients ", "@type": "HowToStep" }, { "text": "Rinse the rice until the water runs clear. Put in a small saucepan with the garlic, half the spring onion and 250ml (1 cup) water, cover and bring to a simmer over medium heat. Reduce the heat to low and cook for 12 mins or until tender and the water is absorbed. Turn off the heat and stand, covered, for at least 5 mins. Season with salt and pepper. Fluff the rice with a fork.\n", "name": "Cook rice ", "@type": "HowToStep" }, { "text": "While the rice is cooking, bring a small saucepan of water to the boil for the eggs. Combine 1 tsp white vinegar and 1 tsp sugar in a large bowl. Add the carrot and toss to combine. Set aside to pickle, tossing occasionally, until needed.\n", "name": "Pickle carrot", "@type": "HowToStep" }, { "text": "Cook 2 eggs in the pan of boiling water for 6 mins for soft-boiled or 8 mins for hard-boiled. Drain, then cool in cold water. Peel and halve the eggs.\n", "name": "Cook eggs", "@type": "HowToStep" }, { "text": "Thinly slice the avocado. Drain the carrot, discarding the pickling liquid. Separate the smoked salmon slices, then coarsely tear into pieces. Divide the rice among bowls and top with the avocado, pickled carrot, salmon and egg. Drizzle with the Japanese dressing and scatter over the remaining spring onion. Enjoy!\n", "name": "Serve up ", "@type": "HowToStep" }, { "text": "To speed up the ripening process, put the avocado in a paper bag and loosely close, then leave on the kitchen bench for a day or two. Add a banana to the bag to make the avocado ripen faster.\n", "name": "Kitchen hack", "@type": "HowToStep" } ], "nutrition": { "calories": "625kcal", "carbohydrateContent": "69.2g", "proteinContent": "23.9g", "fatContent": "26.1g", "@type": "NutritionInformation" }, "recipeYield": 2, "dateCreated": "2023-03-27T00:32:10.324Z" }The logs indicate a key error when updating the
source_urlproperty of the JSON, which confuses me since that's not a known property of the Recipe schema. Does the recipe JSON need to be embedded into a HTML page to be imported?Relevant logs
The text was updated successfully, but these errors were encountered: