Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format the computed per serving nutrition numbers #2662

Closed
dsm1212 opened this issue Oct 2, 2023 · 8 comments
Closed

Format the computed per serving nutrition numbers #2662

dsm1212 opened this issue Oct 2, 2023 · 8 comments
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@dsm1212
Copy link

dsm1212 commented Oct 2, 2023

Tandoor Version

commit d42d784 Author: vabene1111 Date: Tue Aug 29 13:09:38 2023 +0200 Merge branch 'develop'

Setup

Docker / Docker-Compose

Reverse Proxy

SWAG

Other

No response

Bug description

Really minor request: The nutrition per serving values are displaying with 16 decimal accuracy. Can you format these to just a couple decimal places? Thx

Relevant logs

No response

@dsm1212 dsm1212 changed the title Format the computed per service nutrition numbers Format the computed per serving nutrition numbers Oct 2, 2023
@vabene1111 vabene1111 added bug Something isn't working enhancement New feature or request labels Oct 5, 2023
@vabene1111 vabene1111 added this to the 1.5.0 milestone Oct 5, 2023
@vabene1111
Copy link
Collaborator

yes that should definitely be run trough the formatter.

@dsm1212
Copy link
Author

dsm1212 commented Nov 21, 2023

Oddly I still get long numbers most of the time. See below. Is this what you fixed?

image

@dsm1212
Copy link
Author

dsm1212 commented Nov 21, 2023

Maybe latest doesn't have the fix yet. I've got:

Tandoor (HEAD )
commit d42d784
Author: vabene1111
Date: Tue Aug 29 13:09:38 2023 +0200

Merge branch 'develop'

@dsm1212
Copy link
Author

dsm1212 commented Nov 21, 2023

Doh, I see this is the same commit I posted against originally. I guess I should try develop?

@smilerz
Copy link
Collaborator

smilerz commented Nov 21, 2023

Doh, I see this is the same commit I posted against originally. I guess I should try develop?

It appears that you are on the develop branch - just not a current commit.

@dsm1212
Copy link
Author

dsm1212 commented Nov 22, 2023

I checked I'm using latest and the last commit was that aug 29 merge from develop. Is develop safe to switch to?

@smilerz
Copy link
Collaborator

smilerz commented Nov 22, 2023

Beta is safer and you can switch to main branch once it's released.

@dsm1212
Copy link
Author

dsm1212 commented Nov 22, 2023

Beta is safer and you can switch to main branch once it's released.

I managed to get to beta after upgrading postgres from 11 to 15. And this fix is present.

The postgres import/export commands in the doc don't mention that the password needs to be reset via sql for djangouser after import. This is a well known issue with postgres so I was able to find the answer pretty quickly.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants