Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird Behaviour of Servings Field #526

Closed
sebimarkgraf opened this issue Apr 6, 2021 · 4 comments · Fixed by #604
Closed

Weird Behaviour of Servings Field #526

sebimarkgraf opened this issue Apr 6, 2021 · 4 comments · Fixed by #604
Labels
bug Something isn't working

Comments

@sebimarkgraf
Copy link
Contributor

sebimarkgraf commented Apr 6, 2021

Version

v0.15.0 but already existed before

Bug description

When trying to type a new servings number in the servings field the field behaves weirdly depending on the browser.
Numbers are added at the wrong place or cannot be deleted.

Potential Solution

I assume this is due to the "rtl" text direction. As this problem is more noticeable on mobile phones, a fix could include setting
the text direction to "ltr" again and change the styling by adding the spin buttons manually.
One could try to integrate something like this or write a custom version: https://vuejsexamples.com/a-customizable-number-input-spinner-component-for-vuejs/

@sebimarkgraf sebimarkgraf changed the title Weird behaviour of sping buttons on servings input Weird Behaviour of Spinning Buttons of Servings Field Apr 6, 2021
@sebimarkgraf sebimarkgraf changed the title Weird Behaviour of Spinning Buttons of Servings Field Weird Behaviour of Servings Field Apr 6, 2021
@vabene1111
Copy link
Collaborator

Do i understand correctly that this happens when viewing the recipe and not when editing it ?

@vabene1111 vabene1111 added the bug Something isn't working label Apr 6, 2021
@sebimarkgraf
Copy link
Contributor Author

Yes, only when viewing the recipe and adjusting the number in the servings field.
Especially, Safari on iOS seems to struggle, but as far as I know, you don't have an ios device for testing.

@vabene1111
Copy link
Collaborator

yes the old problem 🙈 i will investigate what can be done about this. I never really liked the way the serving field works but so far haven't found a better solution

@Korndaweizen
Copy link

I can confirm this behavior on Android with Chrome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants