Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media file name guessing attack #90

Closed
vabene1111 opened this issue Jun 3, 2020 · 1 comment
Closed

Media file name guessing attack #90

vabene1111 opened this issue Jun 3, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@vabene1111
Copy link
Collaborator

since media file naming is very predictable an attacker could guess media files names and gain access to media files without permission.

This is not a huge security risk as images of recipes are no high risk target but should definitely be fixed by using long, random file names.
@vabene1111 vabene1111 added the bug Something isn't working label Jun 3, 2020
@vabene1111
Copy link
Collaborator Author

fixed by saving the files as <uuid4>_id.png. I did not add a migration to rename existing files as most people will probably care more about loosing an image to a bug in a migration (which i don't think would but might happen). If you did upload any sensitive recipe image just download and re upload it.

If you have many images and really want them renamed i can provide a script to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vabene1111