Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix/#112] Challenge - 레이아웃 수정 #113

Merged
merged 1 commit into from
Jan 19, 2024
Merged

[Fix/#112] Challenge - 레이아웃 수정 #113

merged 1 commit into from
Jan 19, 2024

Conversation

kim-seonwoo
Copy link
Member

👾 작업 내용

  • 챌린지 뷰 관련 레이아웃을 수정하였습니다.
enum ChallengeType {
    case sevenDays
    case fourteenDays
    case completed
}
  • 기존 bool값과 혼용하는 방식에서 모든 파일에서 세 가지 케이스에 따른 분류로 모두 변경하였습니다.

🚀 PR Point

📸 스크린샷

구현 내용 스크린샷
화면종류 image

🚀 기기 대응

기기명 Iphone 13 mini Iphone 14 Iphone 15 pro Iphone SE(3rd)
스크린샷 image image image image

✅ Issue

Resolved #112

@kim-seonwoo kim-seonwoo added 😎선우 선우의 issue 🐞fix 오류 고치는 것 / 수정용 labels Jan 19, 2024
@kim-seonwoo kim-seonwoo added this to the 🚀1차 스프린트🚀 milestone Jan 19, 2024
@kim-seonwoo kim-seonwoo self-assigned this Jan 19, 2024
@kim-seonwoo kim-seonwoo linked an issue Jan 19, 2024 that may be closed by this pull request
[Fix] 챌린지 뷰 UI 레이아웃 수정 #112
Closed
Zoe0929
Zoe0929 reviewed Jan 19, 2024
View reviewed changes
Copy link
Member

@Zoe0929 Zoe0929 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

boyeon0119
boyeon0119 approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@boyeon0119 boyeon0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kim-seonwoo kim-seonwoo merged commit 966d5c3 into develop Jan 19, 2024
@Zoe0929 Zoe0929 deleted the fix/#112-Challenge branch January 19, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zoe0929 Zoe0929 Zoe0929 approved these changes

@boyeon0119 boyeon0119 boyeon0119 approved these changes

Assignees

@kim-seonwoo kim-seonwoo

Labels
🐞fix 오류 고치는 것 / 수정용 😎선우 선우의 issue
Projects
HMH-iOS AppJam Team Plan
Status: Done
Milestone
🚀1차 스프린트🚀
Development

Successfully merging this pull request may close these issues.

[Fix] 챌린지 뷰 UI 레이아웃 수정
3 participants
@kim-seonwoo @Zoe0929 @boyeon0119