-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat [#11] CreateChallenge - pickerView 구현 #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굳굳 ~ 고생하셨습니다 :)
HMH_iOS/HMH_iOS/Presentation/CreateChallenge/Views/SpecificTimePickerView.swift
Outdated
Show resolved
Hide resolved
HMH_iOS/HMH_iOS/Presentation/CreateChallenge/Views/TotalTimePickerView.swift
Outdated
Show resolved
Hide resolved
self.delegate = self | ||
self.dataSource = self |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3. 저는 개인적으로 Picker의 UI를 결정하는 코드만 configurePickerView()
에 포함되게 하고
setDelegate()라는 함수를 따로 만들어서 delegate를 관리하는 게 더 좋을 것 같은데 이 부분은 저희끼리 한번 논의해봅시다!
datasource는 이곳에 있는 게 알맞아보여요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오옹 setDelegate로 도입해보겠습니다~!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
나이스네요
HMH_iOS/HMH_iOS/Presentation/CreateChallenge/Views/TotalTimePickerView.swift
Outdated
Show resolved
Hide resolved
HMH_iOS/HMH_iOS/Presentation/CreateChallenge/Views/SpecificTimePickerView.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p5.기가 막히네요 고생하셧슴니다~~
self.delegate = self | ||
self.dataSource = self |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
나이스네요
👾 작업 내용
TotalTimePickerView
SpecificTimePickerView
🚀 PR Point
📸 스크린샷
✅ Issue
Resolved #11