Fix [#24] tabbar 기기대응 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kim-seonwoo
approved these changes
Jan 8, 2024
| let tabBarHeight: CGFloat = 58.0 | ||
| tabBar.frame.size.height = tabBarHeight + safeAreaHeight | ||
| tabBar.frame.origin.y = view.frame.height - tabBarHeight - safeAreaHeight | ||
| let safeAreaHeight = view.safeAreaInsets.bottom.adjustedHeight |
There was a problem hiding this comment.
p3. 이부분 삼항연산자로 간결하게 할 수 있을듯합니다
Comment on lines
42
to
50
| $0.horizontalEdges.equalToSuperview() | ||
| $0.height.equalTo(100) | ||
|
|
||
| if UIScreen.main.isLongerThan812pt { | ||
| $0.height.equalTo(100.adjusted) | ||
| } else { | ||
| $0.height.equalTo(64) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
p5. 혹시 height만 adjusted 뺀 이유가 있을까요?
Comment on lines
-62
to
-63
| let safeAreaHeight = view.safeAreaInsets.bottom | ||
| let tabBarHeight: CGFloat = 58.0 |
There was a problem hiding this comment.
p4. adjusted height 가능할 것 같기도 합니다!
Comment on lines
69
to
73
| let tabBarHeight: CGFloat = 52.0.adjusted | ||
| tabBar.frame.size.height = tabBarHeight + safeAreaHeight | ||
| tabBar.frame.origin.y = view.frame.height - tabBarHeight - safeAreaHeight | ||
| } else { | ||
| let tabBarHeight: CGFloat = 58.0.adjusted |
Zoe0929
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👾 작업 내용
🚀 PR Point
SE 사이즈 예외처리
tabbarController와 tabView의 사이즈를
UIScreen.main.isLongerThan812pt를 이용해 SE 사이즈는 따로 레이아웃을 잡아줬습니다.tabbarController의 높이 코드입니다.
📸 스크린샷
✅ Issue
Resolved #24