-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat [#29] 나의 챌린지 뷰 Footer Button 완성 #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
구현 너무 고생 많으셨습니다~😎
private func setConstraints() { | ||
contentViewController.view.snp.makeConstraints { | ||
$0.verticalEdges.equalToSuperview() | ||
$0.horizontalEdges.equalToSuperview().inset(20) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p5. 혹시 adjusted 에러가 발생 할 까요?
section.contentInsets = .init(top: 0, leading: 0, bottom: 35, trailing:0) | ||
|
||
|
||
let headerHeight = UIScreen().isLongerThan812pt ? 145 : 165 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p5. 분기 한 이후에는 adjusted 사용 하는게 나을까용?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CompositionalLayout 안에서는 adjusted를 사용하면 레이아웃 에러가 발생합니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아주 나이스합니다~
👾 작업 내용
🚀 PR Point
enviroment
를 이용하여 collectionView content의 너비를 계산합니다.Background
를 적용할 때,safeArea
가 채워지지 않는 문제를 발견했습니다. -로 offset을 주어 그 부분을 채웠습니다.FooterButton
은 SwiftUI로 제작되었습니다. 터치 영역은 추후 수정 예정입니다.📸 스크린샷
🖥️ 기기대응
✅ Issue
Resolved #29