Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat [#49] SignInCompleteViewController 회원가입 완료 화면 구현 #50

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

kim-seonwoo
Copy link
Member

👾 작업 내용

  • SignInCompleteViewController를 구현 하였습니다.
  • 기존 OnboardingBaseViewController의 progressbar를 히든 처리 해서 구현 하였습니다.

🚀 PR Point

  • 온보딩 뷰가 마감되고 메인 탭바 컨트롤러로 이동하게 됩니다.
  • 이때 네비게이션 스택에 온보딩 관련 뷰들이 남으면 안되므로 rootViewController를 바꿔주는 로직을 구현했습니다.
    func didTapButton() {
        let nextViewController = TabBarController()
        let navigationController = UINavigationController(rootViewController: nextViewController)
        let sceneDelegate = UIApplication.shared.connectedScenes.first?.delegate as? SceneDelegate
        guard let delegate = sceneDelegate else {
            return
        }
        delegate.window?.rootViewController = navigationController
    }
  • 이미지는 아직 나오지 않아서 임의로 설정했습니다.

📸 스크린샷

구현 내용 스크린샷
회원가입 완료 Simulator Screen Recording - iPhone SE (3rd generation) - 2024-01-11 at 00 57 13

🚀 기기 대응

기기명 Iphone 13 mini Iphone 14 Iphone 15 pro Iphone SE(3rd)
스크린샷 image image image image

✅ Issue

Resolved #49

@kim-seonwoo kim-seonwoo added 😎선우 선우의 issue 🌈 feat 기능 구현 labels Jan 10, 2024
@kim-seonwoo kim-seonwoo added this to the 🚀1차 스프린트🚀 milestone Jan 10, 2024
@kim-seonwoo kim-seonwoo self-assigned this Jan 10, 2024
@kim-seonwoo kim-seonwoo linked an issue Jan 10, 2024 that may be closed by this pull request
Copy link
Member

@Zoe0929 Zoe0929 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1. 컨벤션 관련해서만 수정해주세요! 고생하셨습니다! 🚀

import Then

final class SignInCompleteViewController: OnboardingBaseViewController {
private let SignInMainLabel = UILabel().then {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1. 여기 빈 줄 하나 넣어주세요!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1. 아래에도 모두 적용되는데, 변수명은 lowerCamelCase 사용해주세요!

Copy link
Contributor

@boyeon0119 boyeon0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나이스하네요~ 고생하셧어요!

@kim-seonwoo kim-seonwoo merged commit 19d28b5 into develop Jan 10, 2024
@kim-seonwoo kim-seonwoo changed the title Feat [#49] SignInCompleteViewController 회원가입 완료 화 Feat [#49] SignInCompleteViewController 회원가입 완료 화aaaaaaaa Jan 12, 2024
@kim-seonwoo kim-seonwoo changed the title Feat [#49] SignInCompleteViewController 회원가입 완료 화aaaaaaaa Feat [#49] SignInCompleteViewController 회원가입 완료 화면 구현 Jan 12, 2024
@Zoe0929 Zoe0929 deleted the feat/#49-SignInSuccess branch June 12, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌈 feat 기능 구현 😎선우 선우의 issue
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feat] 회원가입 성공 뷰 UI 구현
3 participants