-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat [#49] SignInCompleteViewController 회원가입 완료 화면 구현 #50
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1. 컨벤션 관련해서만 수정해주세요! 고생하셨습니다! 🚀
import Then | ||
|
||
final class SignInCompleteViewController: OnboardingBaseViewController { | ||
private let SignInMainLabel = UILabel().then { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1. 여기 빈 줄 하나 넣어주세요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1. 아래에도 모두 적용되는데, 변수명은 lowerCamelCase 사용해주세요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
나이스하네요~ 고생하셧어요!
👾 작업 내용
🚀 PR Point
📸 스크린샷
🚀 기기 대응
✅ Issue
Resolved #49