-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat [#51] 스크린 타임 모니터링 앱 삭제 UI 로직 #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
HMH_iOS/HMH_iOS/Presentation/Challenge/ViewControllers/ChallengeViewController.swift
Show resolved
Hide resolved
@objc private func deleteButtonTapped() { | ||
isDeleteMode.toggle() | ||
challengeCollectionView.reloadData() | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p5. deleteMode의 변화가 감지되면 리로드가 되어있게하는데
위의 isDelegateMode didset기능과 중복되지 않나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그러게욜 두번하는 이유가 잇나,,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오, 삭제해도 괜찮을 것 같네요! 삭제하겠습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아주 야무집니다~!!!
return true | ||
} | ||
|
||
func collectionView(_ collectionView: UICollectionView, didSelectItemAt indexPath: IndexPath) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 마이페이지에서 여정지도랑 상점 셀 눌릴 때 쓰면 되겟군요!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋아요 !! Delegate 냐미 ~
@objc private func deleteButtonTapped() { | ||
isDeleteMode.toggle() | ||
challengeCollectionView.reloadData() | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그러게욜 두번하는 이유가 잇나,,
👾 작업 내용
🚀 PR Point
header를 정의하면서
addTarge
을 해주어야해서 이 경우에만 예외적으로addTarget
함수를 따로 만들지 않았습니다.HMH-iOS/HMH_iOS/HMH_iOS/Presentation/Challenge/Views/ChallengeView.swift
Lines 143 to 151 in 232d540
Property Observer인 didSet을 이용해서 값이 변화하는지 감지 후
collectionView
를reload
해주었습니다.HMH-iOS/HMH_iOS/HMH_iOS/Presentation/Challenge/Views/ChallengeView.swift
Lines 19 to 23 in 232d540
UICollectionViewDelegate
를 사용해서 앱 목록 중 하나를 터치했을 때, 선택 되도록 구현했습니다.HMH-iOS/HMH_iOS/HMH_iOS/Presentation/Challenge/ViewControllers/ChallengeViewController.swift
Lines 65 to 79 in 0a919ce
📸 스크린샷
🚀 기기 대응
✅ Issue
Resolved #51