Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [#36] 목표 시간 설정뷰 #69

Merged
merged 2 commits into from
Jan 13, 2024
Merged

Conversation

Zoe0929
Copy link
Member

@Zoe0929 Zoe0929 commented Jan 13, 2024

👾 작업 내용

변경된 pickerView를 적용한 목표 시간 뷰입니다.

🚀 PR Point

  • SpecificTimePicker가 사라졌습니다.

📸 스크린샷

구현 내용 스크린샷
목표 시간 설정뷰 Simulator Screenshot - iPhone 13 mini - 2024-01-14 at 00 43 01

🚀 기기 대응

기기명 Iphone 13 mini Iphone 14 Iphone 15 pro Iphone SE(3rd)
스크린샷 Simulator Screenshot - iPhone 13 mini - 2024-01-14 at 00 43 01 image Simulator Screenshot - iPhone 15 Pro - 2024-01-14 at 00 47 57 Simulator Screenshot - iPhone SE (3rd generation) - 2024-01-14 at 00 38 58

✅ Issue

Resolved #36

@Zoe0929 Zoe0929 self-assigned this Jan 13, 2024
@Zoe0929 Zoe0929 added 🐰지희 지희의 issue 🎨 style 커스텀 뷰 짜기 🐞fix 오류 고치는 것 / 수정용 and removed 🎨 style 커스텀 뷰 짜기 labels Jan 13, 2024
@Zoe0929 Zoe0929 added this to the 🚀1차 스프린트🚀 milestone Jan 13, 2024
Copy link
Member

@kim-seonwoo kim-seonwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zoe님 수고하셨습니다~🎉

Copy link
Contributor

@boyeon0119 boyeon0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@@ -49,6 +49,11 @@ enum StringLiteral {
static var backgroundViewId = "GrayBackground"
static var appAddFooterViewID = "appAddFooter"
}

enum Time {
static var timeLabel = "시간"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p4. hour은 혹싀 어떠신지,, ㅋ

@Zoe0929 Zoe0929 merged commit efde170 into develop Jan 13, 2024
@Zoe0929 Zoe0929 deleted the feat/#36/ScreenTimeAPI branch January 15, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞fix 오류 고치는 것 / 수정용 🐰지희 지희의 issue
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feat] 스크린 타임 가져오기
3 participants