-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat [#7] 커스텀 HMHNavigationBar 구현 #8
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
boyeon0119
approved these changes
Jan 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
너무 빠릅니다. 속도 맞춰주세요~ 🙏🫢👍
HMH_iOS/HMH_iOS/Presentation/Common/UIComponets/HMHNavigationBar.swift
Outdated
Show resolved
Hide resolved
HMH_iOS/HMH_iOS/Presentation/Common/UIComponets/HMHNavigationBar.swift
Outdated
Show resolved
Hide resolved
HMH_iOS/HMH_iOS/Presentation/Common/UIComponets/HMHNavigationBar.swift
Outdated
Show resolved
Hide resolved
HMH_iOS/HMH_iOS/Presentation/Common/UIComponets/HMHNavigationBar.swift
Outdated
Show resolved
Hide resolved
HMH_iOS/HMH_iOS/Presentation/Common/UIComponets/HMHNavigationBar.swift
Outdated
Show resolved
Hide resolved
Zoe0929
reviewed
Jan 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2. 왕빠르다 ! 고생하셨습니다. 🚀🐹
HMH_iOS/HMH_iOS/Presentation/Common/UIComponets/HMHNavigationBar.swift
Outdated
Show resolved
Hide resolved
HMH_iOS/HMH_iOS/Presentation/Common/UIComponets/HMHNavigationBar.swift
Outdated
Show resolved
Hide resolved
HMH_iOS/HMH_iOS/Presentation/Common/UIComponets/HMHNavigationBar.swift
Outdated
Show resolved
Hide resolved
Zoe0929
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👾 작업 내용
🚀 PR Point
네비게이션바 타입 종류
HMHNavigationBar의 NavigationBarType은 HMH 로고 이미지를 포함하는 네비게이션 바를 표현 한 logo type과
그 외의 일반적인 네비게이션 바 상황을 담은 normal로 case 분류를 하였습니다.
네비게이션바 사용법
다음은 네비게이션 바 사용예시입니다.
ImageLiteral 설정&사용
📸 스크린샷
✅ Issue
Resolved #7