Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix [#96] MyPage 프로필 이미지 변경 #97

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Fix [#96] MyPage 프로필 이미지 변경 #97

merged 1 commit into from
Jan 16, 2024

Conversation

boyeon0119
Copy link
Contributor

👾 작업 내용

  • 마이페이지 프로필을 이미지로 수정했습니다.
  • 함수 이름 수정을 할 예정이엇으나 제 코드엔 없어서 써니님께서 해주시면 될 것 같슴니당

🚀 PR Point

  • 원래 SVG로 햇는데 색이 살짝 이상한 거 같아서 png로 다시 수정햇슴니다.

📸 스크린샷

구현 내용 스크린샷
마이페이지 프로필 이미지

✅ Issue

Resolved #96

@boyeon0119 boyeon0119 added 🙊보연 보연의 issue 🐞fix 오류 고치는 것 / 수정용 labels Jan 16, 2024
@boyeon0119 boyeon0119 added this to the 🚀1차 스프린트🚀 milestone Jan 16, 2024
@boyeon0119 boyeon0119 self-assigned this Jan 16, 2024
Zoe0929
Zoe0929 approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@Zoe0929 Zoe0929 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Approve요 ~

kim-seonwoo
kim-seonwoo approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@kim-seonwoo kim-seonwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look Good To me

@boyeon0119 boyeon0119 merged commit a5b11c5 into develop Jan 16, 2024
@Zoe0929 Zoe0929 deleted the fix/#96-renameAndChangeIcon branch January 19, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zoe0929 Zoe0929 Zoe0929 approved these changes

@kim-seonwoo kim-seonwoo kim-seonwoo approved these changes

Assignees

@boyeon0119 boyeon0119

Labels
🐞fix 오류 고치는 것 / 수정용 🙊보연 보연의 issue
Projects
HMH-iOS AppJam Team Plan
Status: Done
Milestone
🚀1차 스프린트🚀
Development

Successfully merging this pull request may close these issues.

[Fix] 함수 네이밍 수정 및 마이페이지 아이콘 수정
3 participants
@boyeon0119 @Zoe0929 @kim-seonwoo