[fix] 메뉴 추가 API #202
Merged
[fix] 메뉴 추가 API #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parkjyun
requested changes
Oct 8, 2024
| @@ -33,7 +36,10 @@ public HankkiResponse<Void> updateMenu(@PathVariable("storeId") final Long store | |||
| } | |||
|
|
|||
| @PostMapping("/{storeId}/menus") | |||
There was a problem hiding this comment.
단건 추가가 아니라 여러건을 한번에 입력받게 되는데 /menus만으로 충분할까요?
| menuUpdater.save(menu); | ||
| updateLowestPriceInStore(findStore, menu); | ||
| return MenuPostResponse.of(menu); | ||
| public MenuListPostResponse createMenus(final MenusPostCommand commands) { |
There was a problem hiding this comment.
사소하지만 commands 굳이 복수? 앞에 이미 내포 돼 있는듯요
| long storeId, | ||
| List<MenuPostCommand> menu | ||
| ){ | ||
| public static MenusPostCommand of (final long storeId, final List<MenuPostCommand> menu) { |
| Store findStore = storeFinder.findByIdWhereDeletedIsFalse(commands.storeId()); | ||
| List<MenuPostResponse> menus = commands.menu().stream() | ||
| .map(command -> { | ||
| validateMenuNotConflict(findStore, command.name()); |
There was a problem hiding this comment.
하나하나 하는것도 나쁘지 않은데 여러 메뉴 들어왔을 때 쿼리에서 count, in 써서 한번에 검증하는 것도 고민해보시길
| }) | ||
| .toList(); | ||
| updateLowestPriceInStore(findStore); | ||
| return MenuListPostResponse.of(menus); |
Comment on lines
44
to
51
| Store findStore = storeFinder.findByIdWhereDeletedIsFalse(commands.storeId()); | ||
| List<MenuPostResponse> menus = commands.menu().stream() | ||
| .map(command -> { | ||
| validateMenuNotConflict(findStore, command.name()); | ||
| Menu menu = Menu.create(findStore, command.name(), command.price()); | ||
| menuUpdater.save(menu); | ||
| return MenuPostResponse.of(menu); | ||
| }) |
There was a problem hiding this comment.
기획이 말한 거처럼
a 메뉴 있는 상태에서
a,b 메뉴 추가할 때 b만 적용 되는거 ㄱ ㄱ
클라랑 협의해서 알람창에 팅긴 거 표시할건지도 정해야할듯요
src/main/java/org/hankki/hankkiserver/api/menu/service/MenuCommandService.java
Show resolved
Hide resolved
Parkjyun
requested changes
Oct 9, 2024
Comment on lines
43
to
48
| List<MenuPostResponse> menus = command.menu().stream() | ||
| .filter(c -> !validateMenuConflict(findStore, c.name())) | ||
| .map(c -> { | ||
| Menu menu = Menu.create(findStore, c.name(), c.price()); | ||
| menuUpdater.save(menu); | ||
| return MenuPostResponse.of(menu); |
There was a problem hiding this comment.
여기서 메뉴 검증 통과한거 모아놓은 다음에 한번에 저장하는게 낫지 않을까요?
Comment on lines
55
to
56
| private void updateLowestPriceInStore(final Store findStore) { | ||
| int lowestPrice = menuFinder.findAllByStore(findStore).stream() | ||
| .mapToInt(Menu::getPrice) | ||
| .min() | ||
| .orElse(0); | ||
| findStore.updateLowestPrice(lowestPrice); | ||
| findStore.updateLowestPrice(menuFinder.findLowestPriceByStore(findStore)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue 📌
close #201
Description ✔️
To Reviewers
API 테스트 완료