[fix] 버튼 중복 클릭 문제 해결 #227
Merged
[fix] 버튼 중복 클릭 문제 해결 #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t1nm1ksun
approved these changes
Sep 1, 2024
Comment on lines
-39
to
44
| onClick() | ||
| clickable = false | ||
| CoroutineScope(Dispatchers.Main).launch { | ||
| delay(500) // 500밀리초 딜레이 | ||
| onClick() | ||
| delay(500) | ||
| clickable = true | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Screen_recording_20240830_235720.mp4
아무튼 연속 클릭 하고 있는 거임,,!
Uncompleted Tasks 😅
To Reviewers 📢
기존에 0.5초의 딜레이를 주어 중복 클릭을 막아두었지만, 서버 통신에서 0.5초 이상의 시간이 걸리는 경우 (멀티파트라 아무래도 오래 걸리는 듯요 ㅠㅠ) 요청이 여러 번 가는 문제를 확인했습니다. 그래서 Clickable 함수에 suspend를 추가하고 로직을 일부 수정하여 서버통신 완료 후 0.5초의 딜레이를 주는 것으로 로직을 변경하였습니다.
EnrollScreen에 로딩뷰를 추가해두지 않아 중복 클릭의 위험이 더 증가한다고 판단하였습니다. 따라서 이를 방지하고자 (+ 다른 뷰와의 통일성을 유지하고자) EnrollScreen에 로딩뷰를 추가하였습니다.