[chore] 불필요한 코드 제거 #277
Merged
[chore] 불필요한 코드 제거 #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/java/org/sopt/dateroad/data/repositoryimpl/CourseRepositoryImpl.kt # app/src/main/java/org/sopt/dateroad/data/repositoryimpl/UserPointRepositoryImpl.kt # app/src/main/java/org/sopt/dateroad/domain/repository/UserPointRepository.kt # app/src/main/java/org/sopt/dateroad/domain/usecase/PostUsePointUseCase.kt
t1nm1ksun
approved these changes
Sep 30, 2024
Comment on lines
+60
to
+62
| object Duration { | ||
| const val DURATION = "시간" | ||
| } |
There was a problem hiding this comment.
이 놈 어느 피알에서 생긴거지? 없어서 타임라인 앰플 붙이는 피알에서 똑같은거 만들었는뎁...
Comment on lines
-46
to
59
| abstract fun bindTimelineRemoteDataSource(timelineRemoteDataSourceImpl: TimelineRemoteDataSourceImpl): TimelineRemoteDataSource | ||
| abstract fun bindsMyCourseRemoteDataSource(myCourseRemoteDataSourceImpl: MyCourseRemoteDataSourceImpl): MyCourseRemoteDataSource | ||
|
|
||
| @Binds | ||
| @Singleton | ||
| abstract fun bindsMyCourseRemoteDataSource(myCourseRemoteDataSourceImpl: MyCourseRemoteDataSourceImpl): MyCourseRemoteDataSource | ||
| abstract fun bindsProfileDataSource(profileDataSourceImpl: ProfileRemoteDataSourceImpl): ProfileRemoteDataSource | ||
|
|
||
| @Binds | ||
| @Singleton | ||
| abstract fun bindsUserPointRemoteDataSource(userPointRemoteDataSourceImpl: UserPointRemoteDataSourceImpl): UserPointRemoteDataSource | ||
| abstract fun bindTimelineRemoteDataSource(timelineRemoteDataSourceImpl: TimelineRemoteDataSourceImpl): TimelineRemoteDataSource | ||
|
|
||
| @Binds | ||
| @Singleton | ||
| abstract fun bindsProfileDataSource(profileDataSourceImpl: ProfileRemoteDataSourceImpl): ProfileRemoteDataSource | ||
| abstract fun bindsUserPointRemoteDataSource(userPointRemoteDataSourceImpl: UserPointRemoteDataSourceImpl): UserPointRemoteDataSource | ||
| } |
Comment on lines
2
to
16
|
|
||
| object Advertisement { | ||
| const val EDITOR = "에디터 픽" | ||
| const val AD = "광고" | ||
| const val ABOUT = "ABOUT" | ||
| const val HOT = "이달의 HOT" | ||
| } | ||
|
|
||
| object Cost { | ||
| const val EXCESS_100000_TITLE = "10만원 초과" | ||
| const val LESS_THAN_100000_TITLE = "10만원 이하" | ||
| const val LESS_THAN_50000_TITLE = "5만원 이하" | ||
| const val LESS_THAN_30000_TITLE = "3만원 이하" | ||
| } | ||
|
|
t1nm1ksun
approved these changes
Sep 30, 2024
| @@ -32,21 +32,22 @@ class UserInfoLocalDataSourceImpl @Inject constructor( | |||
| } | |||
|
|
|||
| override var accessToken: String | |||
| get() = sharedPreferences.getString(ACCESS_TOKEN, "").toString() | |||
There was a problem hiding this comment.
어 나도 이거 갖다 써야겠다 "" 이건 따로 추출 안했는데
| @@ -8,23 +8,21 @@ import org.sopt.dateroad.data.dataremote.model.response.ResponseNearestTimelineD | |||
| import org.sopt.dateroad.data.dataremote.util.Date | |||
| import org.sopt.dateroad.domain.type.MonthType | |||
|
|
|||
| fun String.toCourseDetailDate(): String = SimpleDateFormat(Date.INPUT_FORMAT, Locale.getDefault()).parse(this)?.let { SimpleDateFormat(Date.COURSE_DETAIL_OUTPUT_FORMAT, Locale.getDefault()).format(it) } ?: "" | |||
# Conflicts: # app/src/main/java/org/sopt/dateroad/presentation/ui/coursedetail/CourseDetailScreen.kt # app/src/main/java/org/sopt/dateroad/presentation/ui/home/HomeScreen.kt # app/src/main/java/org/sopt/dateroad/presentation/util/Constraints.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
N/A
Uncompleted Tasks 😅
To Reviewers 📢