Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix material-ui peer dependency on legacy version #41

Merged
merged 2 commits into from
Jul 13, 2021
Merged

Fix material-ui peer dependency on legacy version #41

merged 2 commits into from
Jul 13, 2021

Conversation

serut
Copy link

@serut serut commented Apr 29, 2021

Hello,

The last stable version of Material UI V0 is :

    "material-ui": "^0.20.2",

I made this PR because, with the last version of NPM, it blocks the npm install when using Dockerhub node 15 image (on CI) :

Could not resolve dependency:
npm ERR! peer material-ui@"^0.17.4 || ^1.0.0-beta.1" from [email protected]
npm ERR! node_modules/mdi-material-ui
npm ERR!   mdi-material-ui@"^4.33.1" from the root project

I will also fix the following message for all these users that use the legacy version as we are ...

npm i
[...]
npm WARN [email protected] requires a peer of material-ui@^0.17.4 || ^1.0.0-beta.1 but none is installed. You must install peer dependencies yourself.

package.json Outdated Show resolved Hide resolved
@leMaik
Copy link
Member

leMaik commented Jul 13, 2021

Thank you, much appreciated. 👍 I'll publish a new version later.
Edit: Released as v4.33.2

@leMaik leMaik merged commit 2683dab into TeamWertarbyte:legacy Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants