Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QProduct and DebugStorageType should be local traits #14

Closed
Tehforsch opened this issue May 26, 2023 · 0 comments · Fixed by #66
Closed

QProduct and DebugStorageType should be local traits #14

Tehforsch opened this issue May 26, 2023 · 0 comments · Fixed by #66

Comments

@Tehforsch
Copy link
Owner

They should be defined and implemented in the calling crate rather than in diman.
For DebugStorageType, this is necessary because otherwise, a mismatch in version of glam will cause an error downstream (since DebugStorageType is only implemented for dimans version of glam)
For QProduct, this will clean up the interface and also allow getting rid of the tuple syntax via a definition like
type Product<Q1, Q2=(), Q3=(), ...> = <Q1 as QProduct<...>>
which is currently not possible because it requires an impl of QProduct for () which we can only give if Dimension is crate-local

This also solves the minor issue of requiring use crate as diman in si/mod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant