Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AaaLib still has no tests #10

Closed
rdeago opened this issue Oct 14, 2022 · 2 comments · Fixed by #21
Closed

AaaLib still has no tests #10

rdeago opened this issue Oct 14, 2022 · 2 comments · Fixed by #21
Assignees
Labels
bug [issue/PR] reports / solves a bug.
Milestone

Comments

@rdeago
Copy link
Member

rdeago commented Oct 14, 2022

Affected version(s)

1.0.60

Is this a regression?

NO - This bug also affected the previous version

Context

There are no tests in this repository.

Also, quite obviously, no coverage reports.

Expected behavior

PR checks should include running tests.

The release workflow should, too.

Actual behavior

dotnet test is executed in the above-mentioned workflows, but it does nothing, as there are no tests.

(I'm getting boring, I know.)

How to reproduce

n/a

Configuration

n/a

Other information

AaaLib being an incubator for Tenacom's procedures and internal standards, it's not only a matter of writing tests. Which unit testing library do we use? Do we also use some helper library, e.g. FluentAssertions? Etc.

It's important to have a standard, so people can "jump" between projects and feel at home.

@rdeago rdeago added the bug [issue/PR] reports / solves a bug. label Oct 14, 2022
@ric15ni
Copy link
Collaborator

ric15ni commented Oct 14, 2022

I'm currently researching libraries and tools we can use. I'm going to open a discussion with the results, as it seems a better approach than stuffing them in an issue.

@ric15ni
Copy link
Collaborator

ric15ni commented Oct 14, 2022

Find the discussion here: #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [issue/PR] reports / solves a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants