Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android,ios): add jsi document & demo #1508

Merged
merged 2 commits into from
Jan 31, 2022

Conversation

bennyzqliu
Copy link
Contributor

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@zoomchan-cxj zoomchan-cxj changed the title Dev/jsi doc feat(android,ios): jsi document Jan 31, 2022
@zoomchan-cxj zoomchan-cxj changed the title feat(android,ios): jsi document feat(android,ios): add jsi document & demo Jan 31, 2022
Copy link
Collaborator

@zoomchan-cxj zoomchan-cxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zoomchan-cxj zoomchan-cxj merged commit 784683e into Tencent:master Jan 31, 2022
zoomchan-cxj pushed a commit that referenced this pull request Feb 9, 2022
* feat(android): jsi document

* feat(ios): jsi document

Co-authored-by: aprilgong <[email protected]>
Co-authored-by: bennyzqliu <[email protected]>
zoomchan-cxj pushed a commit to zoomchan-cxj/Hippy that referenced this pull request Feb 22, 2022
* feat(android): jsi document

* feat(ios): jsi document

Co-authored-by: aprilgong <[email protected]>
Co-authored-by: bennyzqliu <[email protected]>
zoomchan-cxj pushed a commit that referenced this pull request Feb 22, 2022
* feat(android): jsi document

* feat(ios): jsi document

Co-authored-by: aprilgong <[email protected]>
Co-authored-by: bennyzqliu <[email protected]>
@JerryChu JerryChu deleted the dev/jsi_doc branch March 22, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants