Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(android): add breakStrategy prop for Text and TextInput #2285

Merged
merged 11 commits into from
Jul 26, 2022
Merged

feat(android): add breakStrategy prop for Text and TextInput #2285

merged 11 commits into from
Jul 26, 2022

Conversation

iPel
Copy link
Collaborator

@iPel iPel commented Jul 22, 2022

Pre-PR Checklist

  • I added/updated relevant documentation.
  • I followed the Convention Commit guideline with maximum 72 characters to submit commit message.
  • I squashed the repeated code commits.
  • I signed the [CLA].
  • I added/updated test cases to check the change I am making.
  • All existing and new tests are passing.

@github-actions
Copy link

👋 Thanks for your contributing!

🤖: "After a quick scan, I have approved workflows to run."

@github-actions
Copy link

👋 Thanks for your contributing!

🤖: "After a quick scan, I have approved workflows to run."

@iPel iPel changed the title feat(android): add textBreakStrategy prop for Text and TextInput feat(android): add breakStrategy prop for Text and TextInput Jul 22, 2022
@github-actions
Copy link

👋 Thanks for your contributing!

🤖: "After a quick scan, I have approved workflows to run."

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2022 •
edited
Loading

Codecov Report

Merging #2285 (16fc622) into master (9e7fb70) will decrease coverage by 0.60%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2285      +/-   ##
==========================================
- Coverage   62.36%   61.75%   -0.61%     
==========================================
  Files          30       30              
  Lines        1990     1982       -8     
==========================================
- Hits         1241     1224      -17     
- Misses        749      758       +9
Impacted Files Coverage Δ
packages/hippy-vue/src/renderer/list-node.js 0.00% <0.00%> (-53.85%) ⬇️
packages/hippy-vue/src/renderer/native/index.js 81.81% <0.00%> (-3.39%) ⬇️
packages/hippy-vue/src/renderer/element-node.js 82.01% <0.00%> (-1.80%) ⬇️
packages/hippy-vue/src/renderer/text-node.js 100.00% <0.00%> (ø)
packages/hippy-vue/src/renderer/input-node.js 0.00% <0.00%> (ø)
packages/hippy-vue/src/renderer/list-item-node.js 100.00% <0.00%> (ø)
...ges/hippy-vue/src/renderer/native/event/emitter.js 98.11% <0.00%> (ø)
packages/hippy-vue-css-loader/src/css-parser.js 1.16% <0.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cbc769...16fc622. Read the comment docs.

@github-actions
Copy link

👋 Thanks for your contributing!

🤖: "After a quick scan, I have approved workflows to run."

zoomchan-cxj
zoomchan-cxj approved these changes Jul 25, 2022
View reviewed changes
Copy link
Collaborator

@zoomchan-cxj zoomchan-cxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

👋 Thanks for your contributing!

🤖: "After a quick scan, I have approved workflows to run."

@github-actions
Copy link

👋 Thanks for your contributing!

🤖: "After a quick scan, I have approved workflows to run."

@github-actions
Copy link

👋 Thanks for your contributing!

🤖: "After a quick scan, I have approved workflows to run."

@zoomchan-cxj zoomchan-cxj merged commit 47e600a into Tencent:master Jul 26, 2022
@iPel iPel deleted the text_break_strategy branch July 28, 2022 11:59
iPel added a commit to iPel/Hippy that referenced this pull request Jul 29, 2022
@iPel
feat(android): add breakStrategy prop for Text and TextInput (Tencent…
0d13279 
…#2285)
@iPel iPel mentioned this pull request Aug 1, 2022
Closed
6 tasks
zoomchan-cxj pushed a commit that referenced this pull request Aug 1, 2022
@iPel @zoomchan-cxj
feat(android): add breakStrategy prop for Text and TextInput (#2285)
8dd4c03 
* feat(android): add `textBreakStrategy` prop for `Text` and `TextInput`

* feat(android): update demo

* feat(android): update demo

* feat(android): update prop name

* feat(vue): update keb style

* feat(core): resolve pr issues

* feat(core): resolve pr issues

* feat(core): resolve pr issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoomchan-cxj zoomchan-cxj zoomchan-cxj approved these changes

@siguangli siguangli siguangli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iPel @codecov-commenter @zoomchan-cxj @siguangli