Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(voltron): complete dart null safe and rename voltron framework #2541

Merged
merged 5 commits into from
Oct 14, 2022
Merged

feat(voltron): complete dart null safe and rename voltron framework #2541

merged 5 commits into from
Oct 14, 2022

Conversation

henryjin0511
Copy link
Collaborator

Pre-PR Checklist

  • I added/updated relevant documentation.
  • I followed the Convention Commit guideline with maximum 72 characters to submit commit message.
  • I squashed the repeated code commits.
  • I signed the [CLA].
  • I added/updated test cases to check the change I am making.
  • All existing and new tests are passing.

@github-actions
Copy link

👋 Thanks for your contributing!

Our collaborators will review your pull request after all status checks have been passed.

@hippy-service
Copy link

hippy-service bot commented Oct 14, 2022

After a quick scan, I have approved workflows to run.

@lvfen lvfen enabled auto-merge (squash) October 14, 2022 08:02
@hippy-service
Copy link

hippy-service bot commented Oct 14, 2022

After a quick scan, I have approved workflows to run.

@lvfen lvfen merged commit faf6631 into Tencent:v3.0-dev Oct 14, 2022
@henryjin0511 henryjin0511 deleted the feat/dart-null-safe branch October 14, 2022 08:06
skindhu
skindhu reviewed Oct 14, 2022
View reviewed changes
Copy link
Collaborator

@skindhu skindhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skindhu skindhu skindhu left review comments

@lvfen lvfen lvfen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henryjin0511 @skindhu @lvfen